Merged
Conversation
hiro-v
approved these changes
Oct 1, 2020
hiro-v
left a comment
There was a problem hiding this comment.
So many improvements. Keep it up!!! 👌🥺🙄🤟🙆
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
+ Coverage 49.46% 54.12% +4.66%
==========================================
Files 44 44
Lines 3613 3597 -16
==========================================
+ Hits 1787 1947 +160
+ Misses 1826 1650 -176
Continue to review full report at Codecov.
|
lamhoangtung
added a commit
that referenced
this pull request
Dec 26, 2020
* 🐛 Bugs fix and improvement for 0.1.8 (#21) * Resolve merge conflict * Compress CSS * Compressed js * Compress more html * Detached SVG and compress final HTML file * potential fix for #20 * Minor pipeline bug fixed * Minor coverage test increase * 🔖 Update mlconfig 🔖 Env var is now on top of priority in mlconfig * 🚀 🚀 🚀 Update mlchain 0.1.9 🚀 🚀 🚀 - Sentry integration. Fixed #28 - Update better interface for mlconfig.yaml - Put env on the most priority - Handle some exceptions * Update requirements + Fixed sentry when no dsn * 🐛 Higher Priority for Sentry config using env vars + Fixed requirements for Python 3.6 🐛 * 🎉 🎉 🎉 Handle exception + Fixed Sentry break Gunicorn + Better default config🎉 🎉 🎉 Co-authored-by: Hoang Viet <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipelineas well