You have infinite loops in the constructor#16
Open
enimiste wants to merge 1 commit intoTesteSoftware:masterfrom
Open
You have infinite loops in the constructor#16enimiste wants to merge 1 commit intoTesteSoftware:masterfrom
enimiste wants to merge 1 commit intoTesteSoftware:masterfrom
Conversation
the valor attributes doesn't change along the constructor code and while loops condition is based on it. the code blocks on the first loop (and if you fix it it will block on the next one and so on). i replace the while loops by if condition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
valorattributes doesn't change along the constructor code and while loops condition is based on it.the code blocks infinitly on the first loop (and if you fix it it will block on the next one and so on).
i replace the while loops by
if condition.it is not clear what you want to do with the
valorwithcount?if you need to have how many 100 in the valor you just do :
valor/100in any cases this pull request will let your code executes.