Skip to content

Avoid pushing pre-release builds to Docker hub#229

Merged
rvolosatovs merged 2 commits intoTheThingsNetwork:masterfrom
rvolosatovs:fix/228-prerelease-docker
Mar 5, 2019
Merged

Avoid pushing pre-release builds to Docker hub#229
rvolosatovs merged 2 commits intoTheThingsNetwork:masterfrom
rvolosatovs:fix/228-prerelease-docker

Conversation

@rvolosatovs
Copy link
Copy Markdown
Contributor

Summary:

Closes #228

Changes:

@rvolosatovs rvolosatovs added this to the March 2019 milestone Mar 5, 2019
@rvolosatovs rvolosatovs self-assigned this Mar 5, 2019
Copy link
Copy Markdown
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please file a technical debt issue, because I'm against a permanent fork of goreleaser.

The issue is either that we don't publish pre-releases at all (and only tag) and/or use an updated goreleaser that supports this feature / has this patch integrated.

@rvolosatovs rvolosatovs merged commit 8f9ec5d into TheThingsNetwork:master Mar 5, 2019
@rvolosatovs rvolosatovs deleted the fix/228-prerelease-docker branch March 5, 2019 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants