Skip to content

Fix uplink frame counters being limited to 16 bits in Network Server#2876

Merged
rvolosatovs merged 2 commits intoTheThingsNetwork:masterfrom
rvolosatovs:fix/fcnt-limit
Jul 10, 2020
Merged

Fix uplink frame counters being limited to 16 bits in Network Server#2876
rvolosatovs merged 2 commits intoTheThingsNetwork:masterfrom
rvolosatovs:fix/fcnt-limit

Conversation

@rvolosatovs
Copy link
Copy Markdown
Contributor

Summary

Closes https://github.com/TheThingsIndustries/lorawan-stack-support/issues/64?notification_referrer_id=MDE4Ok5vdGlmaWNhdGlvblRocmVhZDk4NDA4MjA5MToxMjg3NzkwNQ%3D%3D#issuecomment-656074683

Changes

  • Add and use MACPayload.FullFCnt

Testing

unit tests

Regressions

Things that depend on uplink FCnt, e.g. ADR

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md. The target branch is set to master if the changes are fully compatible with existing API, database, configuration and CLI.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@rvolosatovs rvolosatovs self-assigned this Jul 9, 2020
@rvolosatovs rvolosatovs added bug Something isn't working c/network server This is related to the Network Server prio/high labels Jul 9, 2020
@rvolosatovs rvolosatovs added this to the July 2020 milestone Jul 9, 2020
@rvolosatovs
Copy link
Copy Markdown
Contributor Author

changing branch reset all the labels, review requests etc. @johanstokking please review

@KrishnaIyer KrishnaIyer added the needs/backport Needs to be backported to previous versions that are maintained label Jul 10, 2020
@rvolosatovs rvolosatovs merged commit 839399a into TheThingsNetwork:master Jul 10, 2020
@rvolosatovs rvolosatovs deleted the fix/fcnt-limit branch July 10, 2020 09:43
rvolosatovs added a commit to rvolosatovs/lorawan-stack-fork that referenced this pull request Jul 10, 2020
This was referenced Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working c/network server This is related to the Network Server needs/backport Needs to be backported to previous versions that are maintained

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants