Some Fixes for Windows from conda.#301
Closed
mingwandroid wants to merge 20 commits intoTheano:masterfrom
Closed
Conversation
Member
|
I'm ok with the changes, execpt for the stdint.h ones, which should use gpuarray/config.h. That header could be modified to only include the bundled copy when necessary though. |
Contributor
Author
|
OK, thanks, I'm on it now. |
Contributor
Author
|
The stdint.h issue I had seems to have gone away now. |
Plus some minor changes: - did `chmod +x setup.py` - added interface for clblas
Plus some minor changes: - did `chmod +x setup.py` - added interface for clblas
- Added tests for BLAS dot - Implementation for CLBlast - modified blas tests from using nested for loops to itertools.product for parametrized tests.
Because for Visual Studio < 2010, we use a bundled version instead and the compile-guards that implement that logic are in gpuarray/config.h
Contributor
Author
|
OK, so I had the wrong end of the stick regarding stdint.h, please see ccc3ba7 for what I hope is the correct fix. |
Member
|
I don't know what happened, but in this PR, you have commits from another PR. To get this merged faster, I'll make another PR with just the right commits. |
Member
|
I cherry-picked the commits in #305 thanks |
Contributor
Author
|
Yeah that's weird, I simply rebased and then force pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.