Fix some memory leaks in libgpuarray#526
Merged
abergeron merged 5 commits intoTheano:masterfrom Sep 13, 2017
Merged
Conversation
abergeron
reviewed
Sep 13, 2017
pygpu/gpuarray.pyx
Outdated
| tot *= newdims[i] | ||
| cdims = <size_t *>calloc(nd, sizeof(size_t)) | ||
| if cdims == NULL: | ||
| free(cdims) |
Member
There was a problem hiding this comment.
If cdims is NULL then it can't be allocated. This is useless.
abergeron
approved these changes
Sep 13, 2017
pygpu/gpuarray.pyx
Outdated
| cdims[i] = d | ||
|
|
||
| array_reshape(res, a, nd, cdims, ord, nocopy) | ||
| free(cdims) |
Member
There was a problem hiding this comment.
This whole free thing should probably be in a try: .. finally since there could be an exception at basically any point that will take us out of the function.
Contributor
Author
There was a problem hiding this comment.
@abergeron I made a new commit to use try-finally block: 714f3a5
abergeron
reviewed
Sep 13, 2017
pygpu/gpuarray.pyx
Outdated
| raise GpuArrayException, "..." | ||
| cdims[i] = d | ||
| try: | ||
| cdef size_t d |
Member
There was a problem hiding this comment.
This needs to stay outside of the try..finally
abergeron
approved these changes
Sep 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to Theano/Theano#6162 .
@nouiz @abergeron