pygpu/tests: Skip tests that require CUDA context if the context is not CUDA#571
Merged
abergeron merged 1 commit intoTheano:masterfrom Apr 23, 2018
Merged
pygpu/tests: Skip tests that require CUDA context if the context is not CUDA#571abergeron merged 1 commit intoTheano:masterfrom
abergeron merged 1 commit intoTheano:masterfrom
Conversation
Contributor
Author
|
@nouiz, are you interested in bug fixes? |
Member
|
Yes we are, however I would fix this differently. The only part of those tests that require a cuda context is the .gpudata access. You could make that part conditional on the context kind and the rest should pass. |
Fixes Theano#491 v2: Do not skip the entire test Signed-off-by: Jan Vesely <[email protected]>
Member
|
@abergeron this PR was updated. Can you review it again? |
Contributor
Author
|
thanks. I didn't know new commits were silent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #491
Signed-off-by: Jan Vesely [email protected]