Conversation
kekulta
reviewed
Jan 12, 2025
| String nameCar = scanner.next(); | ||
|
|
||
| int speed = -1; | ||
| while (speed < 0 || speed > 250) { |
There was a problem hiding this comment.
Здесь лучше так же давать сообщение об ошибке, чтобы пользователь сразу понимал что пошло не так
| String leader = ""; | ||
| int distansLeader = 0; | ||
|
|
||
| public void whoLeader(Car Car) { |
There was a problem hiding this comment.
Больше подошло бы название addNewCar или что-то в таком духе
Comment on lines
+66
to
+67
| String leader = ""; | ||
| int distansLeader = 0; |
There was a problem hiding this comment.
Правильно, что сделал геттер и не обращаешься к переменной напрямую, но так же было бы неплохо сделать их приватными.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.