Merged
Conversation
TonyTroeff
commented
Sep 8, 2023
Member
Author
TonyTroeff
left a comment
There was a problem hiding this comment.
I had no comments after self-reviewing my PR.
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The in-place bitwise operations now accept two constituents (no longer the current instance is assumed to be one of them).
The changes introduced by this PR are not backwards compatible, however, the new changes are still in alpha.
Motivation and Context
It appears that the existing implementation is rather limiting and can cause performance downgrades.
Checklist