Skip to content

Generic types setup extraction improvements#89

Merged
TonyTroeff merged 8 commits intomainfrom
troeff/generic-type-parameters-discovery-improvements
Sep 26, 2023
Merged

Generic types setup extraction improvements#89
TonyTroeff merged 8 commits intomainfrom
troeff/generic-type-parameters-discovery-improvements

Conversation

@TonyTroeff
Copy link
Copy Markdown
Member

@TonyTroeff TonyTroeff commented Sep 24, 2023

Pull Request Description

  • Improved error messages.
  • The provided external configuration (the typesMap parameter) is used to determine the decorating attributes in use.

Motivation and Context

In .NET8 the logic used to check whether an attribute is compiler generated, does not work.

Checklist

  • I have tested these changes thoroughly.
  • I have added/updated relevant documentation.
  • My code follows the project's coding guidelines.
  • I have performed a self-review of my changes.
  • My changes are backwards compatible.

@TonyTroeff TonyTroeff added the feature Something that should be implemented label Sep 24, 2023
@TonyTroeff TonyTroeff self-assigned this Sep 24, 2023
@TonyTroeff TonyTroeff changed the title Generic types setup extraction discovery improvements Generic types setup extraction improvements Sep 24, 2023
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Member Author

@TonyTroeff TonyTroeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no comments after self-reviewing my PR.

@TonyTroeff TonyTroeff merged commit 02ac739 into main Sep 26, 2023
@TonyTroeff TonyTroeff deleted the troeff/generic-type-parameters-discovery-improvements branch September 26, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Something that should be implemented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compiler generated attributes for generic parameters lead to issues with setup extraction

1 participant