chore(ci): add fresh-install failure Slack alert and ignore hono alerts#2648
Merged
nperez0111 merged 2 commits intomainfrom Apr 16, 2026
Merged
chore(ci): add fresh-install failure Slack alert and ignore hono alerts#2648nperez0111 merged 2 commits intomainfrom
nperez0111 merged 2 commits intomainfrom
Conversation
Co-authored-by: Nick Perez <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughDependabot is configured to ignore Changes
Sequence Diagram(s)sequenceDiagram
participant Runner as GitHub Actions Runner
participant Steps as Workflow Steps (checkout, setup, install, build, test...)
participant Slack as Slack Webhook
Runner->>Steps: execute steps with explicit ids
Steps-->>Runner: outcomes per step (success | failure)
alt any step failed
Runner->>Runner: compute failed_step from steps.<id>.outcome
Runner->>Slack: POST failure payload (repo, workflow, run, branch, failed_step)
Slack-->>Runner: 200/timeout (curl handles retries)
else all steps succeeded
Runner-->>Slack: no notification sent
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/dependabot.yml (1)
43-48: Minor redundancy in ignore patterns.The pattern
@hono/*already matches@hono/node-server, so line 47 is redundant (though harmless). You could simplify to justhonoand@hono/*.Also note that
ignoresuppresses both version updates and security advisories. If the demo AI server is publicly accessible or processes any sensitive data, you may want to monitor Hono security advisories separately.♻️ Optional simplification
ignore: # Hono packages are used only in the demo AI server and are not part of # the main editor/runtime surface area. - dependency-name: "hono" - - dependency-name: "@hono/node-server" - dependency-name: "@hono/*"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/dependabot.yml around lines 43 - 48, The ignore list contains a redundant entry: "@hono/node-server" is already matched by "@hono/*"; remove the specific "- dependency-name: "@hono/node-server"" entry and keep "- dependency-name: "hono"" and "- dependency-name: "@hono/*"" instead, and optionally document/consider monitoring Hono security advisories separately since ignore suppresses advisories.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/fresh-install-tests.yml:
- Around line 98-108: The current heredoc assembly of the Slack JSON payload
into the variable payload and the plain curl call to "$SLACK_WEBHOOK_URL" are
fragile: build the JSON safely using jq (e.g., pass the message string variables
into jq to produce a proper {"text":...} JSON) instead of unescaped heredoc,
then replace the curl invocation to include --fail, --retry with backoff,
--connect-timeout and --max-time so HTTP 4xx/5xx and network hangs are surfaced
and transient errors retried; ensure you still pass the generated JSON as --data
"$payload" and keep using "$SLACK_WEBHOOK_URL".
---
Nitpick comments:
In @.github/dependabot.yml:
- Around line 43-48: The ignore list contains a redundant entry:
"@hono/node-server" is already matched by "@hono/*"; remove the specific "-
dependency-name: "@hono/node-server"" entry and keep "- dependency-name: "hono""
and "- dependency-name: "@hono/*"" instead, and optionally document/consider
monitoring Hono security advisories separately since ignore suppresses
advisories.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 44fa17f3-f171-45e3-bd8d-9b9ce1ca18ed
📒 Files selected for processing (2)
.github/dependabot.yml.github/workflows/fresh-install-tests.yml
Co-authored-by: Nick Perez <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add workflow-level Slack failure notifications for Fresh Install Tests (including the failed step), harden webhook payload/transport behavior, and update Dependabot configuration to ignore Hono-related dependencies used only by the demo AI server.
Rationale
The fresh install workflow is intended to surface dependency breakages early. A direct Slack notification shortens time-to-detection and includes enough context to triage immediately. Hardening payload generation and webhook delivery improves reliability and avoids malformed JSON issues. Separately, suppressing Hono alerts reduces noise for packages outside the primary editor/runtime surface.
Changes
.github/workflows/fresh-install-tests.yml:idvalues to each key step.Notify Slack on workflow failurestep gated byif: ${{ failure() }}.jq --null-input --arg text "$message" '{text: $text}'for safe JSON encoding.curl --fail --retry 4 --retry-all-errors --retry-max-time 60 --connect-timeout 10 --max-time 30.SLACK_WEBHOOK_URLsecret is not configured..github/dependabot.yml:ignorerules forhono,@hono/node-server, and@hono/*.Impact
Testing
yaml.safe_load) for modified workflow and dependabot files.Screenshots/Video
N/A
Checklist
Additional Notes
SLACK_WEBHOOK_URLis set for notifications to send.jqis available on GitHub-hosted Ubuntu runners (it is preinstalled onubuntu-latest).Summary by CodeRabbit