[GHA] remove explicit setting of xcode version and fix ByteOrder on Apple M?#1412
Merged
KrisThielemans merged 2 commits intoUCL:masterfrom May 5, 2024
Merged
Conversation
Collaborator
Author
|
Looks like the MacOS image changed to macos-14-arm64, and our ByteOrder checks fail. |
96497a9 to
33f85cc
Compare
Collaborator
Author
|
Not sure what's going on with clang-format, as I ran it with 14.0.0 on Windows with logical results. Anyway.... merging. |
previous version failed on macos-14-arm64. We have a very fragile list of checks. Presumably, CMake does a lot better, so use CMAKE_CXX_BYTE_ORDER in ByteOrderDefine (via config.h)
33f85cc to
5ccb440
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1411