add ProjDataInMemory numerical operations#1439
Merged
KrisThielemans merged 6 commits intoUCL:masterfrom May 31, 2024
Merged
Conversation
- add helper class HigherPrecision to convert float to double ec - Array:sum() now accumulates into a type of higher precision. End result is still in original type.
301a614 to
fad5707
Compare
essentially just expose Array<1,float> methods
now needed for ProjDataInfo::operator!=
swig cannot handle private typedef
ecf091b to
ceaf9af
Compare
[ci skip]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expose Array<1,float> members.
I also had to modify
Array::sum()to do the accumulation at higher precision