Reverting a change that broke the blocks on cylindrical geometry.#1462
Merged
KrisThielemans merged 4 commits intoUCL:masterfrom Jun 21, 2024
Merged
Conversation
added 3 commits
June 20, 2024 08:49
…i using the same logic than in plot_scanner_LORs.py
Contributor
Author
|
@danieldeidda @KrisThielemans This is ready now from my side. The detector coordinate test could clearly be improved since we didn't notice the wrong geometry, but the python plotting tool shows that it is now correct. |
Collaborator
|
Thanks @markus-jehl. Could you add a plot here for future reference? Please also modify the release_6.2.htm. @danieldeidda please check. |
Contributor
Author
|
|
Collaborator
|
having a look now |
Collaborator
|
just for my understanding could it be possible to see the plot showing the wrong geometry |
Collaborator
|
See #1390 |
danieldeidda
approved these changes
Jun 21, 2024
Collaborator
danieldeidda
left a comment
There was a problem hiding this comment.
this makes sense to me. I am happy for this to be approved
Collaborator
|
Excellent. Squash merge ok? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Reverted a part of commit: 42bf1e9
Testing performed
Related issues
fixes #1390
Checklist before requesting a review
documentation/release_XXX.mdhas been updated with any functionality change (if applicable)