Scatter forward projector setter#1530
Merged
KrisThielemans merged 5 commits intoUCL:masterfrom Nov 27, 2024
Merged
Conversation
Collaborator
Author
|
Ready to merge. |
KrisThielemans
requested changes
Nov 25, 2024
KrisThielemans
approved these changes
Nov 27, 2024
Collaborator
|
ah, sorry, can you add a line to |
Collaborator
|
I'll squash-merge if ok |
Collaborator
|
looks like there's a conflict with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Introduces the ability to set and retrieve a forward projector for scatter estimation, used in mask forward projection, in the ScatterEstimation class. Also adds a keymap parser.
Related issues
Fixes #1527
Checklist before requesting a review
documentation/release_XXX.mdhas been updated with any functionality change (if applicable)