no longer use default for radionuclide if name is empty#1574
Merged
KrisThielemans merged 1 commit intoUCL:masterfrom Mar 30, 2025
Merged
no longer use default for radionuclide if name is empty#1574KrisThielemans merged 1 commit intoUCL:masterfrom
KrisThielemans merged 1 commit intoUCL:masterfrom
Conversation
we were assuming default values, but it's better to just state explicitly it's unknown.
9f98ff2 to
059d9ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we were assuming default values, but it's better to just state explicitly it's unknown.
Fixes #1480
Warning: this branch will be rebased on
master