When computing sensitivity, avoid a superfluous ProjDataInMemory in most cases#1617
Merged
KrisThielemans merged 2 commits intoUCL:masterfrom Oct 2, 2025
Merged
Conversation
…ost cases Optimise code such that we only use a ProjDataInMemory when using TOF projectors and non-TOF projector for the sensitivity. Fixes UCL#1614
Collaborator
Author
|
@christanmod this should fix the memory problem with the sensitivity calculation, so you should be able to norm/attenuation for Quadra now. Still only with the ray-tracing matrix though. Can you please try it? |
Collaborator
Author
|
Sorry @DANAJK ignore the review request |
Collaborator
|
I have more on this. I will push in a week or so.
…On Sat, Sep 20, 2025 at 10:30 AM Kris Thielemans ***@***.***> wrote:
*KrisThielemans* left a comment (UCL/STIR#1617)
<#1617 (comment)>
Sorry @DANAJK <https://github.com/DANAJK> ignore the review request
—
Reply to this email directly, view it on GitHub
<#1617 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACEUB7TJOTZIIZVVTVHT3HL3TVQHBAVCNFSM6AAAAACHBJK4IOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMJVGAYDIMBWGY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Collaborator
Author
|
@NikEfth What other things do you have? This PR is tiny (but important). Let's not make it too complicated... Possibly a separate PR? |
Collaborator
|
Ok, then
…On Sun, Sep 21, 2025 at 2:47 AM Kris Thielemans ***@***.***> wrote:
*KrisThielemans* left a comment (UCL/STIR#1617)
<#1617 (comment)>
@NikEfth <https://github.com/NikEfth> What other things do you have? This
PR is tiny (but important). Let's not make it too complicated... Possibly a
separate PR?
—
Reply to this email directly, view it on GitHub
<#1617 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACEUB7SUA4XKSZQQMHGT7GL3TZCXDAVCNFSM6AAAAACHBJK4IOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMJVGU2DMMZRHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
[ci skip]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimise code such that we only use a ProjDataInMemory when using TOF projectors and non-TOF projector for the sensitivity.
Fixes #1614