Python: addition of as_array() and fill(numpy.ndarray)#1632
Merged
KrisThielemans merged 6 commits intoUCL:masterfrom Oct 16, 2025
Merged
Python: addition of as_array() and fill(numpy.ndarray)#1632KrisThielemans merged 6 commits intoUCL:masterfrom
KrisThielemans merged 6 commits intoUCL:masterfrom
Conversation
Collaborator
Author
|
Current status: @markus-jehl @christanmod, want to give it a go? Would be good to have some timings on the difference with |
Collaborator
Author
|
This should be ready aside from:
Would still be great to get some info on timing |
- adds C++/swig implementations of these functions in Array - adds C++/swig implementation of fill(numpy.ndarray) for ProjDataInMemory
109e7f1 to
66b7f89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
np_arr = stir_object.as_array()andstir_object.fill(np_arr)directly via SWIG. These should be faster than thestirextrafunctions, as they are implemented in C++.Usage is the same as in SIRF, which makes it easier to convert SIRF to STIR Python.