Skip to content

Changing Uize Overrides#55

Open
quentinbrooks wants to merge 3 commits intoUIZE:masterfrom
quentinbrooks:master
Open

Changing Uize Overrides#55
quentinbrooks wants to merge 3 commits intoUIZE:masterfrom
quentinbrooks:master

Conversation

@quentinbrooks
Copy link
Copy Markdown

Presently, Uize static functions can be overridden. moduleUrlResolver, in particular, is specifically designed to be overridden. This means Uize.js must be loaded, then moduleUrlResolver must be changed, and then the rest of the modules would need to be loaded. This would require special-casing the Uize.js inclusion, which we currently load as part of our concatenated js payload.

This changes Uize so you can specify overrides before Uize.js is loaded, that way any existing override code can be moved before the Uize.js load without requiring changes.

We have tested this change for a week on QA and didn't notice any issues, and now it is live on www.zazzle.com .

Let me know if anything is fishy about this code, or if you think it should be done in a different way.

Thanks!
Quentin Brooks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant