This repository was archived by the owner on Jan 9, 2020. It is now read-only.
Merged
Conversation
1fd6b80 to
a985b5b
Compare
notebooks_preprocess.py
Outdated
| with open(str(path), encoding='utf8') as f: | ||
| return header + f.read() | ||
| solution = f.read() | ||
| if solution == '': |
notebooks_preprocess.py
Outdated
| """Find and non load magic or blank lines in a solution cell.""" | ||
| for line in cell_text.split('\n'): | ||
| m = re.match('#\s?%load.*', line) | ||
| if not m and line != '': |
d4b8064 to
ef3d01e
Compare
ef3d01e to
6f1ff28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should check for empty solution files and if any solution cells have any content other than the load magic (indicating that we accidentally left the solution filled in). Should fail at first blush as we have an empty solution and filled in solutions.
Will close #250 #252 #253