ABOUT_THESE_NOTEBOOKS.md as a suggested order of approach#267
ABOUT_THESE_NOTEBOOKS.md as a suggested order of approach#267brianmapes wants to merge 0 commit intoUnidata:masterfrom brianmapes:master
Conversation
jrleeman
left a comment
There was a problem hiding this comment.
Thanks for the contribution! At one point we had a table of contents and it kept getting out of date, so we killed it until we can circle back and automate it. I like the about these notebooks file. Maybe we should have it render as part of the website? Thoughts @dopplershift
|
This is a nice outline to have, thanks! @jrleeman if you have a place where you think this would fit in the rendered docs, I'm all ears. Regardless, this is a nice thing to have alongside the notebooks. |
environment.yml
Outdated
| - pip: | ||
| - python-awips | ||
| - mpldatacursor | ||
| - drilsdown |
There was a problem hiding this comment.
Brian, did you mean to push this? Because these don't look like changes we should take. If it was a mistake, we can handle.
|
Oh, no I didn’t mean to push that to your world.
I guess pull requests include too many things.
|
|
In fact, I think I I only added that to my fork today.
Do standing pull requests get bigger with further edits of a fork?
|
|
When you create a pull request, GitHub essentially creates a link between the pull request and the branch you are asking to be "pulled in"--in this case the master branch on your fork of the python workshop materials. Every time you push to that branch, this pull request is updated. That's a great thing for when we're collaboratively going back and forth on changes, since it means you can easily update a pull request. It's less great in this case. At any rate, that link is severed once the PR is merged, which means it's really our fault for not merging in your contribution in a timely fashion. |
|
@brianmapes - is it okay if I blast away that environment.yml change? It will go away on your master branch as I would be pushing there. |
|
Yes that’s fine.
|
That directory is a little blank -- just alphabetical. Could use a bit of a front face. Not sure if this is the right way, but a suggestion.