Skip to content

Ported LWRP RenderPass examples#11

Merged
phi-lira merged 3 commits intoUnity-Technologies:universal/new-examplesfrom
prefrontalcortex:port-lwrp-renderpass-samples
Jul 30, 2020
Merged

Ported LWRP RenderPass examples#11
phi-lira merged 3 commits intoUnity-Technologies:universal/new-examplesfrom
prefrontalcortex:port-lwrp-renderpass-samples

Conversation

@hybridherbst
Copy link
Copy Markdown
Contributor

@hybridherbst hybridherbst commented Feb 12, 2020

The examples here are pretty great and I was always wondering why they're not also in this repo.

Since 7.2.0 is out now I thought it would be a nice opportunity to port them over as WIP samples, so here they are. I ported them to 2019.3 / URP 7.2.0 and adjusted them for this repo (e.g. automatically loading correct SRP profile on scene load).

20200212-010852_Unity
20200212-010909_Unity
20200212-011010_Unity

They'll need a bit folder structure cleanup, so I added them to the "WIP" section for now.

@hybridherbst
repair sounds and jump speed
5b3a412
@hybridherbst
ported over examples from UnityTechnologies/LWRPScriptableRenderPass_…
97fa780 
…ExampleLibrary#7

* adjusted to auto-load right profiles
* roughly cleaned up folder structure
* ported PPv2 to new postprocessing to not introduce more dependencies
@hybridherbst
replace int2 with Vector2Int to remove Mathematics dependency
650d23e
@hybridherbst
Copy link
Copy Markdown
Contributor Author

hybridherbst commented Apr 23, 2020

@phi-lira do you think you or someone else could over this to merge it in, or tell me what changes are required?

@andybak
Copy link
Copy Markdown

andybak commented Apr 27, 2020

Could we at least have a comment from someone at Unity that's either:

  1. Yes - we just need to find the time. It's on our to do list
  2. Sorry - we'll probably never find the time as we're ultra busy
  3. We don't think this should be merged.
  4. We might merge but it needs some tweaks

In the absence of 1 to 4 we can only conclude

  1. We never look at pull requests

which is a bit disheartening!

@phi-lira phi-lira requested a review from Verasl April 27, 2020 11:52
@phi-lira
Copy link
Copy Markdown
Contributor

phi-lira commented Apr 27, 2020

Oh sorry about this. I guess we forgot to review it as we were not added to PR originally. I just added @Verasl but he is out of office now, I'm putting a note to have a chat with him when he's back.

@hybridherbst
Copy link
Copy Markdown
Contributor Author

hybridherbst commented Jun 25, 2020 •
edited
Loading

Bump! @phi-lira @Verasl

@phi-lira phi-lira changed the base branch from master to universal/new-examples July 30, 2020 13:40
@phi-lira
Copy link
Copy Markdown
Contributor

phi-lira commented Jul 30, 2020

Changed this to working branch in our repo. Will take it from there.

@phi-lira phi-lira merged commit 8a24f7f into Unity-Technologies:universal/new-examples Jul 30, 2020
@phi-lira phi-lira mentioned this pull request Jul 30, 2020
Merged
@andybak
Copy link
Copy Markdown

andybak commented Jul 30, 2020

Apologies if I've overlooked them but there's no mention of the new examples in the readme is there?

I can see that being the crucial entrypoint for someone trying to figure out how to do x in URP.

@phi-lira
Copy link
Copy Markdown
Contributor

phi-lira commented Jul 31, 2020

I'll have a follow up PR to change the examples, then I'll add wiki pages / changes to README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Verasl Verasl Awaiting requested review from Verasl

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hybridherbst @andybak @phi-lira