feat: Added "OnServerStopped" event [MPDSE-10]#2420
Merged
RikuTheFuffs merged 9 commits intodevelopfrom Mar 14, 2023
Merged
Conversation
… server (or host player) to notify that the server is no longer active. [CI] Added tests for OnServerStopped
Contributor
Author
|
Note about the tests I added: |
…trigger only on the client (or host player) to notify that the client just started or is no longer active * test Added a more robust/wider range of tests, that covers the Started/Stopped events for client, server and hosts
NoelStephensUnity
approved these changes
Mar 13, 2023
Member
NoelStephensUnity
left a comment
There was a problem hiding this comment.
Looks good to me pending the minor XML API adjustments.
👍
com.unity.netcode.gameobjects/Tests/Runtime/NetworkManagerEventsTests.cs
Outdated
Show resolved
Hide resolved
|
Paolo Abela seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
…ent times in Host vs Client-only / Server-only mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses this feature request , allowing users to write code that is executed when a server stops (I.E: for sending post-game analytics in a dedicated game server instance)
Changelog
Testing and Documentation