merging develop into release/1.5.2#2634
Merged
ShadauxCat merged 1 commit intorelease/1.5.2from Jul 21, 2023
Merged
Conversation
* update excluding getTypeName, * update Make sure internal classes can access NetworkBehaviour.NetworkVariableFields in runtime builds. * update to get RPCS working temporarily. * style Adding comments about the RPC stuff since it is a bit more complicated than the previous two issues. * style updating and adding comments to regions of code changed in order to easily distinguish the changes made for each issue type. * update Missed two files. * Updated the ILPP code to work correctly with CoreCLR: - delegates are no longer fields, but types - internal virtual functions can't be overridden in child classes anymore, so they have to be changed from `IsAssembly` to `IsFamilyOrAssembly` in ILPP - Internal fields changed to `IsFamily` can no longer be accessed within the assembly, and need to be `IsFamilyOrAssembly` instead. With those changes, previous workarounds are no longer needed, so I reverted them. * update removing commented out code. wrapping the rpc table generation log info so it only logs to the console when log mode is set to developer. * style Fixing whitespace issue. * revert __RpcParams to internal * update adding change log entry * update Moving the version number back down to v1.5.1 * Fixed validator failures. * Update package.json Reverting back to v1.5.2 to validate compatibility testing * Add Validation exceptions for 1.5.2 * Apparently the meta file is also needed. --------- Co-authored-by: Kitty Draper <[email protected]>
NoelStephensUnity
approved these changes
Jul 21, 2023
NoelStephensUnity
added a commit
that referenced
this pull request
Aug 1, 2023
* merging develop into release/1.5.2 (#2634) * chore: tagging 1.5.2 in the changelog (#2640) --------- Co-authored-by: Kitty Draper <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.