Implement RFC #5: RPC Queue#413
Merged
NoelStephensUnity merged 14 commits intodevelopfrom Jan 5, 2021
Merged
Conversation
com.unity.multiplayer.mlapi/Editor/CodeGen/PostProcessorAssemblyResolver.cs
Show resolved
Hide resolved
com.unity.multiplayer.mlapi/Editor/CodeGen/PostProcessorAssemblyResolver.cs
Show resolved
Hide resolved
com.unity.multiplayer.mlapi/Editor/CodeGen/PostProcessorAssemblyResolver.cs
Show resolved
Hide resolved
com.unity.multiplayer.mlapi/Runtime/Configuration/MLAPIConstants.cs
Outdated
Show resolved
Hide resolved
com.unity.multiplayer.mlapi/Runtime/Core/RPCMethods/NetworkedBehaviour.PerformanceClientRpc.cs
Outdated
Show resolved
Hide resolved
com.unity.multiplayer.mlapi/Runtime/Core/RPCMethods/NetworkedBehaviour.PerformanceServerRpc.cs
Outdated
Show resolved
Hide resolved
com.unity.multiplayer.mlapi/Runtime/Core/RPCQueue/RPCQueueProcessing.cs
Outdated
Show resolved
Hide resolved
mattwalsh-unity
suggested changes
Dec 16, 2020
Contributor
mattwalsh-unity
left a comment
There was a problem hiding this comment.
Fundamentally I'm a thumbs up, but just a few questions / observerations
|
|
- Fixed an issue where on latest 21.1 you could not build ILPP without some PrivateCorelib issues - Removed UTP package as it causes issues with burst and ILPP that needs to be resolved at some future point - Updated Burst to latest 1.43 and Mono to 1.10.1-preview.1 (this is the legit package not the shim package) All this is compat back to 2018.4
…d moved some core around to be more clean and consistent.
b73ec58 to
f7bfc9a
Compare
0xFA11
reviewed
Dec 18, 2020
com.unity.multiplayer.mlapi/Runtime/SceneManagement/NetworkSceneManager.cs
Outdated
Show resolved
Hide resolved
Reverted InternalManager from public to internal. Removed unused (and evidently added) GetCurrentSceneIndex from SceneManagement
0xFA11
reviewed
Dec 18, 2020
com.unity.multiplayer.mlapi/Runtime/Serialization/Pooled/BitStreamPool.cs
Outdated
Show resolved
Hide resolved
wackoisgod
reviewed
Dec 21, 2020
wackoisgod
reviewed
Dec 21, 2020
0xFA11
reviewed
Dec 21, 2020
0xFA11
reviewed
Dec 21, 2020
0xFA11
reviewed
Dec 21, 2020
0xFA11
reviewed
Dec 21, 2020
0xFA11
reviewed
Dec 21, 2020
0xFA11
reviewed
Dec 21, 2020
0xFA11
reviewed
Dec 21, 2020
0xFA11
reviewed
Dec 21, 2020
com.unity.multiplayer.mlapi/Runtime/Core/RPCQueue/RPCQueueHistoryFrame.cs
Show resolved
Hide resolved
0xFA11
reviewed
Dec 21, 2020
com.unity.multiplayer.mlapi/Runtime/Core/RPCQueue/RPCQueueHistoryFrame.cs
Show resolved
Hide resolved
0xFA11
reviewed
Dec 21, 2020
com.unity.multiplayer.mlapi/Runtime/Core/RPCQueue/RPCQueueHistoryFrame.cs
Show resolved
Hide resolved
0xFA11
reviewed
Dec 21, 2020
com.unity.multiplayer.mlapi/Runtime/Core/RPCQueue/RPCQueueHistoryFrame.cs
Show resolved
Hide resolved
0xFA11
reviewed
Dec 21, 2020
0xFA11
reviewed
Dec 21, 2020
0xFA11
reviewed
Dec 21, 2020
0xFA11
reviewed
Dec 21, 2020
0xFA11
reviewed
Dec 21, 2020
0xFA11
approved these changes
Dec 21, 2020
Contributor
0xFA11
left a comment
There was a problem hiding this comment.
I think I'm also overall 👍 for this PR but asking for a few extra comments and clarifications (optionally).
Member
Author
NoelStephensUnity
left a comment
There was a problem hiding this comment.
Reviewed all comments and have compiled a list of all suggestions for two new Jira Tasks:
RpcQueue Revisited: Generic minor changes
RpcQueue and InternalMessages: Needs further investigation as to be solution to sending non-rpc based internal messages.
Contributor
|
a minor thing but you should've "Squash and Merge" @NoelStephensUnity :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements RFC #5: RPC Queue (tracked by #476)
This is a cleaner version of the feature/rpcqueue branch with only the RPC Queue specific changes and the changes from:
PR #407 and PR #408
RFC for this is pending review and will be attached to this PR once it is approved