Skip to content

fix: Removed per-tick runtime allocations by reusing memory between ticks #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JesseOlmer merged 2 commits into from
Mar 18, 2021
Merged

fix: Removed per-tick runtime allocations by reusing memory between ticks #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81a058a
fix: Removed per-tick runtime allocations by reusing memory between t…
becksebenius-unity Mar 17, 2021
8300db2
Updated `AddNonDuplicateData` to remove runtime allocation from linq …
becksebenius-unity Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions com.unity.multiplayer.mlapi/Runtime/Profiling/PerformanceDataManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,31 +5,29 @@ namespace MLAPI.Profiling
{
internal static class PerformanceDataManager
{
private static PerformanceTickData s_ProfilerData;
private static PerformanceTickData s_ProfilerData = new PerformanceTickData();
private static int s_TickId;

internal static void BeginNewTick()
{
s_TickId = Math.Max(s_TickId, 0);
s_ProfilerData = new PerformanceTickData
{
TickId = s_TickId++,
};
s_ProfilerData.Reset();
s_ProfilerData.TickId = s_TickId++;
}

internal static void Increment(string fieldName, int count = 1)
{
s_ProfilerData?.Increment(fieldName, count);
s_ProfilerData.Increment(fieldName, count);
}

internal static void AddTransportData(IReadOnlyDictionary<string, int> transportProfilerData)
{
s_ProfilerData?.AddNonDuplicateData(transportProfilerData);
s_ProfilerData.AddNonDuplicateData(transportProfilerData);
}

internal static PerformanceTickData GetData()
{
return s_ProfilerData;
}
}
}
}
12 changes: 10 additions & 2 deletions com.unity.multiplayer.mlapi/Runtime/Profiling/PerformanceTickData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,12 @@ public void Increment(string fieldName, int count = 1)

public void AddNonDuplicateData(IReadOnlyDictionary<string, int> transportProfilerData)
{
var nonDuplicates = transportProfilerData.Where(entry => !m_TickData.HasData(entry.Key));
foreach (var entry in nonDuplicates)
foreach (var entry in transportProfilerData)
{
if (m_TickData.HasData(entry.Key))
{
continue;
}
Comment on lines -20 to +24
Copy link
Copy Markdown
Contributor

@kvassall-unity kvassall-unity Mar 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this fine now. the function name makes it clear enough

Copy link
Copy Markdown
Contributor

@mattwalsh-unity mattwalsh-unity Mar 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, and also +1 as we've been talking about moving away from LINQ in the library

m_TickData.Add(entry.Key, entry.Value);
}
}
Expand All @@ -32,5 +35,10 @@ public bool HasData(string fieldName)
{
return m_TickData.HasData(fieldName);
}

public void Reset()
{
m_TickData.Clear();
}
}
}