feat: Integrate reactive Dark Mode detection for all desktop OS#368
Merged
leandroBorgesFerreira merged 5 commits intoWriteopia:mainfrom May 7, 2025
Merged
feat: Integrate reactive Dark Mode detection for all desktop OS#368leandroBorgesFerreira merged 5 commits intoWriteopia:mainfrom
leandroBorgesFerreira merged 5 commits intoWriteopia:mainfrom
Conversation
…daptive top bar on Windows - Replace the use of isSystemInDarkTheme with isSystemInDarkMode to handle real-time theme changes across all desktop operating systems. - Add Windows top bar configuration using setWindowsAdaptiveTitleBar(). - Currently, the top bar only follows the system theme and does not sync with the user's explicit preferences. more information at https://github.com/kdroidFilter/Platform-Tools?tab=readme-ov-file#-dark-mode-detection-module
Collaborator
|
Thanks for your contribution! It will be nice that now the bars in Linux and Windows will follow the system's colour. |
Contributor
Author
|
it seems my library is having problems with pro guards, i will inspect the problem |
Bumped platformtoolsDarkmodedetector to 0.2.8 and downgraded AGP to 8.6.1 to ensure compatibility and stability. Changes help maintain synchronization between dependencies.
Contributor
Author
|
I fixed the problem with Proguard, can we try again? |
leandroBorgesFerreira
requested changes
Mar 17, 2025
Collaborator
|
Hi @kdroidFilter. I think this is just fine. Please remove the downgrade and fix the Ktlint change and we can merge this 🎉 🎉 🎉 |
Replaced `isSystemInDarkTheme()` with `isSystemInDarkMode()` for dark mode detection using the `platformtools` library. Updated dependency version to `0.2.9` and replaced references in theme configuration and desktop app setup. Ensure compatibility and alignment with the updated library API.
Contributor
Author
|
it should be good :) |
Collaborator
|
Hi @kdroidFilter Somehow I didn't see your message, sorry about it. |
leandroBorgesFerreira
approved these changes
May 7, 2025
Collaborator
|
Hey! Thanks for the help with the colour theme of the desktops apps and congrats on your first contribution!! 🎉 🎉 🎉 🎉 🎉 🎉 🎉 |
Contributor
Author
|
With pleasure, sorry for the wait :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Integrate reactive Dark Mode detection for all desktop OS and adaptive top bar on Windows
more information at https://github.com/kdroidFilter/Platform-Tools?tab=readme-ov-file#-dark-mode-detection-module