Skip to content

Always showing edit icon for equations when on mobile #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leandroBorgesFerreira merged 1 commit into from
Jul 29, 2025
Merged

Always showing edit icon for equations when on mobile #493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ dagCommand {
printModulesInfo = true
}

extra["sdkVersion"] = "0.12.0"
extra["sdkVersion"] = "0.12.1"
5 changes: 3 additions & 2 deletions writeopia_ui/src/commonMain/kotlin/io/writeopia/ui/drawer/content/EquationDrawer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ import io.writeopia.ui.model.DrawConfig
import io.writeopia.ui.model.DrawInfo

class EquationDrawer(
private val showEditAlways: Boolean,
private val equationToImageUrl: String,
private val customBackgroundColor: Color,
private val config: DrawConfig,
Expand All @@ -57,7 +58,7 @@ class EquationDrawer(
private val moveRequest: (Action.Move) -> Unit,
private val onSelected: (Boolean, Int) -> Unit,
private val receiveExternalFile: (List<ExternalFile>, Int) -> Unit,
private val onEditClick: (Int) -> Unit
private val onEditClick: (Int) -> Unit,
) : StoryStepDrawer {

@Composable
Expand Down Expand Up @@ -147,7 +148,7 @@ class EquationDrawer(
Spacer(modifier = Modifier.width(6.dp))

Crossfade(
targetState = isHovered,
targetState = isHovered || showEditAlways,
label = "iconCrossFade",
animationSpec = tween(durationMillis = 200)
) { show ->
Expand Down
1 change: 1 addition & 0 deletions writeopia_ui/src/commonMain/kotlin/io/writeopia/ui/drawer/factory/CommonDrawers.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ object CommonDrawers {
val loadingDrawer = LoadingDrawer()

val equationsDrawer = EquationDrawer(
showEditAlways = !isDesktop,
equationToImageUrl = equationToImageUrl ?: "",
customBackgroundColor = MaterialTheme.colorScheme.surfaceVariant,
dragIconWidth = dragIconWidth,
Expand Down