Skip to content

Side menu width #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leandroBorgesFerreira merged 1 commit into from
Jan 8, 2026
Merged

Side menu width #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ore/common_ui/src/androidMain/kotlin/io/writeopia/commonui/buttons/UiConstants.android.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
package io.writeopia.commonui.buttons

actual fun verticalPaddingCommonButton(): Int = 10
actual fun sideMenuDefaultWidth(): Float = SIDE_MENU_WIDTH_MOBILE
5 changes: 5 additions & 0 deletions ...ication/core/common_ui/src/commonMain/kotlin/io/writeopia/commonui/buttons/UiConstants.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
package io.writeopia.commonui.buttons

const val SIDE_MENU_WIDTH_MOBILE = 500F
const val SIDE_MENU_WIDTH_DESKTOP = 280F

expect fun verticalPaddingCommonButton(): Int

expect fun sideMenuDefaultWidth(): Float
1 change: 1 addition & 0 deletions ...eopia/commonui/buttons/UiConstants.jvm.kt → ...eopia/commonui/buttons/UiConstants.jvm.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
package io.writeopia.commonui.buttons

actual fun sideMenuDefaultWidth(): Float = SIDE_MENU_WIDTH_DESKTOP
actual fun verticalPaddingCommonButton(): Int = 6
1 change: 1 addition & 0 deletions .../core/common_ui/src/nativeMain/kotlin/io/writeopia/commonui/buttons/UiConstants.native.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
package io.writeopia.commonui.buttons

actual fun verticalPaddingCommonButton(): Int = 6
actual fun sideMenuDefaultWidth(): Float = SIDE_MENU_WIDTH_MOBILE
1 change: 1 addition & 0 deletions ...cation/core/common_ui/src/webMain/kotlin/io/writeopia/commonui/buttons/UiConstants.web.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
package io.writeopia.commonui.buttons

actual fun verticalPaddingCommonButton(): Int = 6
actual fun sideMenuDefaultWidth(): Float = SIDE_MENU_WIDTH_DESKTOP
2 changes: 1 addition & 1 deletion ...ion/core/theme/src/commonMain/kotlin/io/writeopia/extensions/UiConfigurationExtensions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ fun UiConfiguration.toEntity() = UiConfigurationEntity(
fun UiConfigurationEntity.toModel() = UiConfiguration(
userId = user_id,
colorThemeOption = ColorThemeOption.fromText(color_theme_option) ?: ColorThemeOption.SYSTEM,
sideMenuWidth = side_menu_width?.toFloat() ?: 500F,
sideMenuWidth = side_menu_width?.toFloat() ?: 280F,
font = Font.fromLabel(font_family)
)
5 changes: 3 additions & 2 deletions ...hell/src/commonMain/kotlin/io/writeopia/global/shell/viewmodel/GlobalShellKmpViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import io.writeopia.common.utils.download.DownloadParser
import io.writeopia.common.utils.download.DownloadState
import io.writeopia.common.utils.icons.IconChange
import io.writeopia.common.utils.toList
import io.writeopia.commonui.buttons.sideMenuDefaultWidth
import io.writeopia.commonui.dtos.MenuItemUi
import io.writeopia.commonui.extensions.toUiCard
import io.writeopia.core.folders.repository.folder.NotesUseCase
Expand Down Expand Up @@ -345,12 +346,12 @@ class GlobalShellKmpViewModel(
override fun toggleSideMenu() {
val width = showSideMenuState.value

sideMenuWidthState.value = if (width.dp < 5.dp) 500F else 0F
sideMenuWidthState.value = if (width.dp < 5.dp) sideMenuDefaultWidth() else 0F
saveMenuWidth()
}

override fun saveMenuWidth() {
val width = sideMenuWidthState.value ?: 500F
val width = sideMenuWidthState.value ?: sideMenuDefaultWidth()

viewModelScope.launch(Dispatchers.Default) {
val uiConfiguration =
Expand Down