Preserve aspect ratio when downsizing images, add custom scaling factor flag#325
Merged
tylervick merged 6 commits intoXCTestHTMLReport:mainfrom May 11, 2023
tylervick:tvick/resize-scaling
Merged
Preserve aspect ratio when downsizing images, add custom scaling factor flag#325tylervick merged 6 commits intoXCTestHTMLReport:mainfrom tylervick:tvick/resize-scaling
tylervick merged 6 commits intoXCTestHTMLReport:mainfrom
tylervick:tvick/resize-scaling
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardcoded 200px is generally too small for usability after downsizing. Additionally, there are cases when the maxWidth was exceeded and resulted in a modified aspect ratio (such as iPad landscape).
Changes:
--downsize-scale-factorflag, enabling override of the scale factorPotentially resolves #293