Ольга Блохина. Практическая работа#2
Closed
olya-woo wants to merge 2 commits intoYandex-Practicum:mainfrom
Closed
Conversation
| } else if (b == 2 | b == 3 | b == 4) { | ||
| amountOfRubles = String.format("%.2f", floatAmount) + " рубля"; | ||
| } else { | ||
| amountOfRubles = String.format("%.2f", floatAmount) + " рублей"; |
There was a problem hiding this comment.
Код amountOfRubles = String.format("%.2f", floatAmount) повторяется в каждой ветке, лучше его вынести после if-else
| amountOfRubles = String.format("%.2f", floatAmount) + " рублей"; | ||
| } else if (b == 1) { | ||
| amountOfRubles = String.format("%.2f", floatAmount) + " рубль"; | ||
| } else if (b == 2 | b == 3 | b == 4) { |
| public void writeRuble(double floatAmount) { | ||
| int amount = (int) Math.floor(floatAmount); | ||
| int a = amount % 100; | ||
| int b = a % 10; |
There was a problem hiding this comment.
Лучше дать названия более понятные, чтобы другим программистам с первого взгляда было ясно, что они значат
| product.name = scanner.next(); | ||
| listProduct = listProduct + product.name + "\n"; | ||
| boolean isRightPrice = false; | ||
| while (!isRightPrice) { |
There was a problem hiding this comment.
Можно обойтись без переменной, тут писать while (true), а в месте, где нужен выход из цикла - писать break
sn00pg0d
referenced
this pull request
in sn00pg0d/Java-Module-Project-YP
Dec 28, 2022
Домашнее задание Спринт №2 29/12/22
myCherryPie
added a commit
to myCherryPie/Java-Module-Project-YP-PracticalWork1
that referenced
this pull request
Jan 8, 2024
практическая работа 1, правки от 1ого ревью
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.