Skip to content

Python assignment 1#1

Open
Ygong63 wants to merge 3 commits intomainfrom
assignment-1
Open

Python assignment 1#1
Ygong63 wants to merge 3 commits intomainfrom
assignment-1

Conversation

@Ygong63
Copy link
Copy Markdown
Owner

@Ygong63 Ygong63 commented May 1, 2024

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

implementing an Anagram Checker function

What did you learn from the changes you have made?

how to sort characters in a string

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Create two sets from the characters of each string. If the sets are equal, it means the strings contain the same characters, just in different orders, and hence are anagrams of each other. Otherwise, they are not anagrams.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Understand the logic

How were these changes tested?

changes were tested by running the Anagram Checker function with various test cases

A reference to a related issue in your repository (if applicable)

@mentions of the person or team responsible for reviewing proposed changes (At least 2 people)

@michaeladrouillard
@juliagallucci

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! code is well executed and concise. One comment would be to better comment your code for improved clarity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants