Fix packages property's example syntax#2748
Open
oleole39 wants to merge 1 commit intoYunoHost:mainfrom
Open
Conversation
09da27b to
68c844b
Compare
68c844b to
7447544
Compare
Contributor
Author
|
Err... actually we also find the format I removed in this PR: https://github.com/YunoHost-Apps/pihole_ynh/blob/22e6708e48f7f61dd67a7fbf549894c616369b4b/manifest.toml#L89 Both are working I guess. Do we want to migrate to a specific format or should we tell about the two formats in the doc ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far 'packages' property in
manifest.tomlis meant to be formatted as a comma-separated string. Cf. https://github.com/search?q=org%3AYunoHost-Apps+path%3Amanifest.toml+resources.apt&type=code