Open
Conversation
xindizhang
approved these changes
Dec 2, 2025
xindizhang
left a comment
There was a problem hiding this comment.
Excellent work! Your code is clean and well-written and your PR description is clear. Assignment 1 is complete – no changes needed.
Please see my minor suggestion for future improvement:
- The
sorted()function already returns a list, so you do not need to convert the words to lists; that way your code will be cleaner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I updated the assignment 1.ipynb file with my code for the questions in the assignment
What did you learn from the changes you have made?
I learned how to create an anagram_checker function in python
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
No, I systematically considered the steps for creating the function based on the question requirements
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I did not face any challenges
How were these changes tested?
Yes
A reference to a related issue in your repository (if applicable)
Checklist
Yes