forked from testdouble/java-testing-example
-
Notifications
You must be signed in to change notification settings - Fork 0
Add BenchmarkTest00005 servlet for encryption #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aaronpynos
wants to merge
1
commit into
main
Choose a base branch
from
aaronpynos-patch-15
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| /** | ||
| * OWASP Benchmark v1.2 | ||
| * | ||
| * <p>This file is part of the Open Web Application Security Project (OWASP) Benchmark Project. For | ||
| * details, please see <a | ||
| * href="https://owasp.org/www-project-benchmark/">https://owasp.org/www-project-benchmark/</a>. | ||
| * | ||
| * <p>The OWASP Benchmark is free software: you can redistribute it and/or modify it under the terms | ||
| * of the GNU General Public License as published by the Free Software Foundation, version 2. | ||
| * | ||
| * <p>The OWASP Benchmark is distributed in the hope that it will be useful, but WITHOUT ANY | ||
| * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR | ||
| * PURPOSE. See the GNU General Public License for more details. | ||
| * | ||
| * @author Dave Wichers | ||
| * @created 2015 | ||
| */ | ||
| package org.owasp.benchmark.testcode; | ||
|
|
||
| import java.io.IOException; | ||
| import javax.servlet.ServletException; | ||
| import javax.servlet.annotation.WebServlet; | ||
| import javax.servlet.http.HttpServlet; | ||
| import javax.servlet.http.HttpServletRequest; | ||
| import javax.servlet.http.HttpServletResponse; | ||
|
|
||
| @WebServlet(value = "/crypto-00/BenchmarkTest00005") | ||
| public class BenchmarkTest00005 extends HttpServlet { | ||
|
|
||
| private static final long serialVersionUID = 1L; | ||
|
|
||
| @Override | ||
| public void doGet(HttpServletRequest request, HttpServletResponse response) | ||
| throws ServletException, IOException { | ||
| doPost(request, response); | ||
| } | ||
|
|
||
| @Override | ||
| public void doPost(HttpServletRequest request, HttpServletResponse response) | ||
| throws ServletException, IOException { | ||
| // some code | ||
| response.setContentType("text/html;charset=UTF-8"); | ||
|
|
||
| String param = ""; | ||
| if (request.getHeader("BenchmarkTest00005") != null) { | ||
| param = request.getHeader("BenchmarkTest00005"); | ||
| } | ||
|
|
||
| // URL Decode the header value since req.getHeader() doesn't. Unlike req.getParameter(). | ||
| param = java.net.URLDecoder.decode(param, "UTF-8"); | ||
|
|
||
| // Code based on example from: | ||
| // http://examples.javacodegeeks.com/core-java/crypto/encrypt-decrypt-file-stream-with-des/ | ||
| // 8-byte initialization vector | ||
| // byte[] iv = { | ||
| // (byte)0xB2, (byte)0x12, (byte)0xD5, (byte)0xB2, | ||
| // (byte)0x44, (byte)0x21, (byte)0xC3, (byte)0xC3033 | ||
| // }; | ||
| java.security.SecureRandom random = new java.security.SecureRandom(); | ||
| byte[] iv = random.generateSeed(8); // DES requires 8 byte keys | ||
|
|
||
| try { | ||
| javax.crypto.Cipher c = javax.crypto.Cipher.getInstance("DES/CBC/PKCS5Padding"); | ||
|
|
||
| // Prepare the cipher to encrypt | ||
| javax.crypto.SecretKey key = javax.crypto.KeyGenerator.getInstance("DES").generateKey(); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| java.security.spec.AlgorithmParameterSpec paramSpec = | ||
| new javax.crypto.spec.IvParameterSpec(iv); | ||
| c.init(javax.crypto.Cipher.ENCRYPT_MODE, key, paramSpec); | ||
|
|
||
| // encrypt and store the results | ||
| byte[] input = {(byte) '?'}; | ||
| Object inputParam = param; | ||
| if (inputParam instanceof String) input = ((String) inputParam).getBytes(); | ||
| if (inputParam instanceof java.io.InputStream) { | ||
| byte[] strInput = new byte[1000]; | ||
| int i = ((java.io.InputStream) inputParam).read(strInput); | ||
| if (i == -1) { | ||
| response.getWriter() | ||
| .println( | ||
| "This input source requires a POST, not a GET. Incompatible UI for the InputStream source."); | ||
| return; | ||
| } | ||
| input = java.util.Arrays.copyOf(strInput, i); | ||
| } | ||
| byte[] result = c.doFinal(input); | ||
|
|
||
| java.io.File fileTarget = | ||
| new java.io.File( | ||
| new java.io.File(org.owasp.benchmark.helpers.Utils.TESTFILES_DIR), | ||
| "passwordFile.txt"); | ||
| java.io.FileWriter fw = | ||
| new java.io.FileWriter(fileTarget, true); // the true will append the new data | ||
| fw.write( | ||
| "secret_value=" | ||
| + org.owasp.esapi.ESAPI.encoder().encodeForBase64(result, true) | ||
| + "\n"); | ||
| fw.close(); | ||
| response.getWriter() | ||
| .println( | ||
| "Sensitive value: '" | ||
| + org.owasp | ||
| .esapi | ||
| .ESAPI | ||
| .encoder() | ||
| .encodeForHTML(new String(input)) | ||
| + "' encrypted and stored<br/>"); | ||
|
|
||
| } catch (java.security.NoSuchAlgorithmException | ||
| | javax.crypto.NoSuchPaddingException | ||
| | javax.crypto.IllegalBlockSizeException | ||
| | javax.crypto.BadPaddingException | ||
| | java.security.InvalidKeyException | ||
| | java.security.InvalidAlgorithmParameterException e) { | ||
| response.getWriter() | ||
| .println( | ||
| "Problem executing crypto - javax.crypto.Cipher.getInstance(java.lang.String,java.security.Provider) Test Case"); | ||
| e.printStackTrace(response.getWriter()); | ||
| throw new ServletException(e); | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The DES cipher used in
javax.crypto.Cipher.getInstance (with algorithm string "DES/CBC/PKCS5Padding")is insecure. Consider using AES.Line 63 | CWE-327 | Priority score 867 | Learn more about this vulnerability