Skip to content

fix: fetch aToken symbol name on add#1968

Merged
grothem merged 1 commit intomainfrom
fix/add-token
Feb 29, 2024
Merged

fix: fetch aToken symbol name on add#1968
grothem merged 1 commit intomainfrom
fix/add-token

Conversation

@grothem
Copy link
Copy Markdown
Collaborator

@grothem grothem commented Feb 22, 2024 •
edited
Loading

General Changes

  • Updates the 'add token' logic to fetch the token symbol from the contract. Previously it was assumed that all aToken symbols just had 'a' prefixed onto the underlying asset symbol name, which is not the case

Developer Notes

In order to minimize the surface area of changes, I assumed that if an empty string is passed in for the symbol, it should be fetched from the contracts.

Author Checklist

Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.

  • The base branch is set to main
  • The title is using Conventional Commit formatting
  • The Github issue has been linked to the PR in the Development section
  • The General Changes section has been filled out
  • Developer Notes have been added (optional)

If the PR is ready for review:

  • The PR is in Open state and not in Draft mode
  • The Ready for Dev Review label has been added

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code style generally follows existing patterns
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)
  • Code changes have been quality checked in the ephemeral URL
  • QA verification has been completed
  • There are two or more approvals from the core team
  • Squash and merge has been checked

@height
Copy link
Copy Markdown

height bot commented Feb 22, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@grothem grothem added Ready for QA Review Ready for QA engineer reviews Ready for Dev Review Read for frontend engineer reviews labels Feb 22, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 22, 2024

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 528.69 KB (🟡 +6 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Twelve Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 86.79 KB (🟢 -5.99 KB) 615.48 KB
/404 16.28 KB (🟡 +1 B) 544.97 KB
/500 16.69 KB (🟡 +1 B) 545.38 KB
/faucet 38.77 KB (🟢 -4.72 KB) 567.46 KB
/governance 97.89 KB (🟢 -3.49 KB) 626.58 KB
/governance/ipfs-preview 111.35 KB (🟡 +1 B) 640.04 KB
/governance/v3/proposal 137.66 KB (🟢 -3.48 KB) 666.34 KB
/history 47.41 KB (🟢 -4.2 KB) 576.1 KB
/markets 38.8 KB (🟡 +2 B) 567.49 KB
/reserve-overview 34.75 KB (🟢 -5.44 KB) 563.44 KB
/staking 33.36 KB (🟢 -3.46 KB) 562.05 KB
/v3-migration 48.63 KB (🟢 -703 B) 577.32 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 22, 2024

@MareskoY MareskoY added QC Passed and removed Ready for QA Review Ready for QA engineer reviews labels Feb 23, 2024
@grothem grothem merged commit ff221b2 into main Feb 29, 2024
@grothem grothem deleted the fix/add-token branch February 29, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@foodaka foodaka foodaka approved these changes

+1 more reviewer

@MareskoY MareskoY MareskoY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

QC Passed Ready for Dev Review Read for frontend engineer reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grothem @foodaka @MareskoY