Merged
Conversation
AndyNicks
approved these changes
May 19, 2022
stmoreau
approved these changes
May 19, 2022
QuintinWillison
suggested changes
May 19, 2022
Contributor
QuintinWillison
left a comment
There was a problem hiding this comment.
The change log can be thinned out a bit... e.g. the JWT test related issue was closed as no longer reproducible; the update URLs in readme issue doesn't improve anything for customers in using the SDK. We need to keep an eye on reducing noise for customers in change logs, please.
Member
Author
|
@QuintinWillison Good spot, I did already trim the generated changelog a bit but must have missed that one. |
QuintinWillison
approved these changes
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.