Add system_provided to extra_requires#40
Conversation
JonoYang
commented
May 15, 2024
* Update tests Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
|
@pombredanne We have about ~8 tests that have different filetype or mimetypes between the linux and macos test runs: 1e3c70c Do you have any ideas on how to normalize the difference in filetype/mimetype? Should we keep both results and check against them? |
@JonoYang I think we should just do this, also encountered this in a different branch |
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
035e9dd to
6b47191
Compare
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
eb924a7 to
a20795a
Compare
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
a20795a to
cb41983
Compare
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
@JonoYang Thanks++
I've added the mac/linux libmagic system provided test expectations as seperate files to make the tests pass on macos arm CI, and linux arm CI
I've also tried different versions of ubuntu arm, these are all supported, but there are little differences in type results so I've added for only one version.
These are added as seperate test expectation files and the ~ in the filename is not ideal, we would want to update commoncode and the way we handle these tests later.