Closed
Conversation
|
Could you update the |
Contributor
|
👋 Hey @IronSean, Thanks for this! It can be difficult to review package dependency updates in a safe manner due to the large number of changes. I've bumped all the minor versions in #192 For fixing #133, we'll need to making some major version updates which will require a new major version of this action. |
Author
|
@joshmgross I'm 10% disappointed I don't get to count as a contributor since you opened your own PR, but 90% happy that the fix is in and merged quickly 👍 |
Contributor
|
Oops, sorry about that @IronSean. I added you to https://github.com/actions/github-script/releases/tag/v5.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of oktokit api methods were unavailable in the current version of this action, I bumped them to their highest available non-breaking versions. There's a version 5.. of @octokit/plugin-rest-endpoint-methods but it moves all of the API endpoints from
oktokit.*tooktokit.rest.*which would be a breaking change for users of the github-script action, so I leave that as a future exercise.You can test my fork with
ironsean/github-script@v-test.Fixes #133