Merged
Conversation
Contributor
Author
|
@joshmgross does this address your comments on #57? |
joshmgross
approved these changes
Aug 21, 2020
konradpabjan
approved these changes
Aug 24, 2020
Contributor
konradpabjan
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the PR ❤️
I noticed that we don't need dist/index.js anymore since we have separate pre and post steps:
Lines 56 to 57 in 3019d15
The entire file should be safety deleted now. I'll go ahead and take care of removing that before releasing the next version of setup-java.
tdfacer
pushed a commit
to ifit/setup-java
that referenced
this pull request
Oct 7, 2025
* Quick fix for 32-bit architecture support. * Validate arch at input Co-authored-by: Émile Grégoire <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55
Supersedes #57 and responds to comments in that PR.