[#911] Add support for separator in CSVBuilder#1201
Merged
pcreux merged 4 commits intoactiveadmin:masterfrom May 10, 2012
LTe:911-add-separator-option-to-csv-builder
Merged
[#911] Add support for separator in CSVBuilder#1201pcreux merged 4 commits intoactiveadmin:masterfrom LTe:911-add-separator-option-to-csv-builder
pcreux merged 4 commits intoactiveadmin:masterfrom
LTe:911-add-separator-option-to-csv-builder
Conversation
Contributor
LTe
commented
Apr 4, 2012
Contributor
|
I like this idea! What do you think about something this as syntax instead: ActiveAdmin.register Post do
csv :separator => ';' do
column :title
column :body
end
endThe reason I suggest this way is because it is more consistent with the way that AA typically allows declarations as part of the enclosing block. Think of things like the title of the |
Contributor
Author
|
I agree - code updated ;) |
Contributor
|
This is really nice. Good work! |
Contributor
There was a problem hiding this comment.
Could you make this step default to the "," separator and update the scenarios accordingly?
pcreux
added a commit
that referenced
this pull request
May 10, 2012
…lder [#911] Add support for separator in CSVBuilder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.