Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: adcloud/api-client-ruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: increase-timeout
Choose a base ref
...
head repository: adcloud/api-client-ruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 18 commits
  • 11 files changed
  • 4 contributors

Commits on May 28, 2013

  1. Added paginator which does automatic pagination and implemented it in… 

    … the reports controller
    Ross Crawford-d'Heureuse committed May 28, 2013
    Configuration menu
    Copy the full SHA
    720a115 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2013

  1. renamed to endless_pages and made includable as mixing.. also support… 

    …s passing in a block to allow for per row iteration over the result set
    Ross Crawford-d'Heureuse committed May 29, 2013
    Configuration menu
    Copy the full SHA
    661e49e View commit details
    Browse the repository at this point in the history

  2. Upgraded endless_pages mixing to be cleaner

    Ross Crawford-d'Heureuse committed May 29, 2013
    Configuration menu
    Copy the full SHA
    02e05e8 View commit details
    Browse the repository at this point in the history

  3. Added booking_id so that the class does not die when v2 provides book… 

    …ing_id… also added accessor that will return campaign_id if present but if not then will use booking_id so that we are forwards and backwards compatible
    Ross Crawford-d'Heureuse committed May 29, 2013
    Configuration menu
    Copy the full SHA
    6d1f96d View commit details
    Browse the repository at this point in the history

  4. added EndlessPages Mixin and instantiated

    Ross Crawford-d'Heureuse committed May 29, 2013
    Configuration menu
    Copy the full SHA
    5465cb0 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2013

  1. Merge branch 'increase-timeout' into paginator 

    Conflicts:
	lib/adcloud/report.rb
    Ross Crawford-d'Heureuse committed Jun 3, 2013
    Configuration menu
    Copy the full SHA
    30e4fc0 View commit details
    Browse the repository at this point in the history

  2. made find_by_name valuable statically

    Ross Crawford-d'Heureuse committed Jun 3, 2013
    Configuration menu
    Copy the full SHA
    affa352 View commit details
    Browse the repository at this point in the history

  3. changed logger to be debug and not info

    Ross Crawford-d'Heureuse committed Jun 3, 2013
    Configuration menu
    Copy the full SHA
    aeaa73e View commit details
    Browse the repository at this point in the history

  4. Merge pull request #6 from adcloud/paginator 

    Added paginator which does automatic pagination and implemented it in th...
    @rosscdh
    rosscdh committed Jun 3, 2013
    Configuration menu
    Copy the full SHA
    ed4f5bd View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2013

  1. 1. Added to_s to adcloudapi exception so that we can just output ex a… 

    …nd not ex.message (seems to be what everyone is doing and will help with debugging)

2. Added better exception handling.. in the else case the api was simply returning a standard error with the response.status.. which is pretty useless in some cases (ssl,timeouts,etc) so now it throws ab UnknownError that acts in the standard adcloud manner
    Ross Crawford-d'Heureuse committed Jun 7, 2013
    Configuration menu
    Copy the full SHA
    b61e412 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2013

  1. Merge pull request #7 from adcloud/better-exceptions 

    1. Added to_s to adcloudapi exception so that we can just output ex and ...
    @rosscdh
    rosscdh committed Jun 10, 2013
    Configuration menu
    Copy the full SHA
    21fbecd View commit details
    Browse the repository at this point in the history

  2. updated version

    @martinotten
    martinotten committed Jun 10, 2013
    Configuration menu
    Copy the full SHA
    b3dff83 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:adcloud/api-client-ruby

    @martinotten
    martinotten committed Jun 10, 2013
    Configuration menu
    Copy the full SHA
    78cd862 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2013

  1. pagination skipped the last page

    @martinotten
    martinotten committed Jun 12, 2013
    Configuration menu
    Copy the full SHA
    ba7b2c1 View commit details
    Browse the repository at this point in the history

  2. actually use the page for the pagination … wicked

    @martinotten
    martinotten committed Jun 12, 2013
    Configuration menu
    Copy the full SHA
    f338967 View commit details
    Browse the repository at this point in the history

  3. bumped patchlevel

    @martinotten
    martinotten committed Jun 12, 2013
    Configuration menu
    Copy the full SHA
    9d01aa0 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2013

  1. added tests for endless_pages

    @martinotten
    martinotten committed Jun 13, 2013
    Configuration menu
    Copy the full SHA
    6ed6f13 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2015

  1. Merge pull request #9 from adcloud/pagination-tests 

    added tests for endless_pages
    @martinotten
    martinotten committed Nov 23, 2015
    Configuration menu
    Copy the full SHA
    7d0d6b7 View commit details
    Browse the repository at this point in the history
Loading