Conversation
Conflicts: lib/adcloud/version.rb
… the reports controller
lib/adcloud/paginator.rb
Outdated
Member
There was a problem hiding this comment.
don't think self.new is correct here. this depends on the kind of object requested.
Contributor
Author
There was a problem hiding this comment.
what does this line do?
Contributor
Author
There was a problem hiding this comment.
exacly.. sorry jsut refreshed.
…s passing in a block to allow for per row iteration over the result set
…ing_id… also added accessor that will return campaign_id if present but if not then will use booking_id so that we are forwards and backwards compatible
Conflicts: lib/adcloud/report.rb
Contributor
There was a problem hiding this comment.
Should virtus than not be enforced somehow? Maybe throw an exception if its not included?
Contributor
Author
There was a problem hiding this comment.
not sure how this is enforced in ruby-land
Member
|
|
rosscdh
added a commit
that referenced
this pull request
Jun 3, 2013
Added paginator which does automatic pagination and implemented it in th...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added paginator which does automatic pagination and implemented it in th...e reports controller