Open
Conversation
DwardEE
approved these changes
Nov 25, 2025
DwardEE
left a comment
There was a problem hiding this comment.
Great work!
Everything looks good. There is no big issues. For the update question, it seems that you used two approaches: Approach 1 deletes all but rn=1 which destroys data. Approach 2 uses correct logic but table was already modified. So just a small heads up so no changes are needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PULL REQUEST TITLE: UofT-DSI | sql - Assignment 2
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I was trying to use window functions, string manipulations, cross joins, and insert, delete, update statements.
What did you learn from the changes you have made?
I learned about logical models type1 and type, and window functions.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
No there was no other approach.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
No challenges
How were these changes tested?
I tested the changes using DB Browser for SQLite
A reference to a related issue in your repository (if applicable)
None
Checklist