Merged
Conversation
js-yaml downgraded due to a bug on @latest
Codecov Report
@@ Coverage Diff @@
## master #264 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 65 65
Lines 1698 1730 +32
Branches 322 367 +45
=========================================
+ Hits 1698 1730 +32
Continue to review full report at Codecov.
|
shazron
requested changes
Feb 10, 2022
Member
shazron
left a comment
There was a problem hiding this comment.
Reviewed the code, lightly tested it, LGTM. The only thing to fix is the node-16 build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A few of the dependencies have been deprecated.
Replaced them && fixed unit test + eslint errors.
require.requireActual:jest.requireActualoclif/plugin-helpcan be found in@oclif/corecli-uxdeprecated, use@oclif/coreinstead.Related Issue
Motivation and Context
To keep the repo up to date.
Currently, the
masterbranch has:35 moderate severity vulnerabilities
A list of deprecated dependencies.
How Has This Been Tested?
unit tests
Screenshots (if appropriate):
Types of changes
Checklist: