Skip to content

Activations don't have names, actions do ...#265

Merged
purplecabbage merged 2 commits intomasterfrom
purplecabbage-patch-1
May 10, 2022
Merged

Activations don't have names, actions do ...#265
purplecabbage merged 2 commits intomasterfrom
purplecabbage-patch-1

Conversation

@purplecabbage
Copy link
Copy Markdown
Member

@purplecabbage purplecabbage commented May 10, 2022 •
edited
Loading

USAGE
$ aio runtime:activation:list [ACTIVATION_NAME] // <<== this should be [ACTION_NAME]

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@purplecabbage
Activations don't have names, actions do ...
244bd11 
USAGE
  $ aio runtime:activation:list [ACTIVATION_NAME] // <<== this should be [ACTION_NAME]
@purplecabbage
Update list.test.js
4cd9c48
rabbah
rabbah approved these changes May 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@rabbah rabbah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented May 10, 2022 •
edited
Loading

Codecov Report

Merging #265 (4cd9c48) into master (734a6d2) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #265   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           65        65           
  Lines         1698      1698           
  Branches       322       322           
=========================================
  Hits          1698      1698
Impacted Files Coverage Δ
src/commands/runtime/activation/list.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 734a6d2...4cd9c48. Read the comment docs.

@purplecabbage purplecabbage merged commit ccd2812 into master May 10, 2022
@purplecabbage purplecabbage deleted the purplecabbage-patch-1 branch May 10, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rabbah rabbah rabbah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@purplecabbage @rabbah