This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Clean up tern web workers whenever we re-init the tern server, or close ...#3983
Merged
dloverin merged 3 commits intoadobe:masterfrom May 24, 2013
Merged
Clean up tern web workers whenever we re-init the tern server, or close ...#3983dloverin merged 3 commits intoadobe:masterfrom
dloverin merged 3 commits intoadobe:masterfrom
Conversation
…se a project. If we don't call terminate on the worker, it appears that the worker, and all the memory it's using will never get collected. So when we were switching projects, we were leaving behind orphaned workers, resulting in a large memory leak. To enable re-initing the web worker I had to change around the logic - now the worker sends a message when it is done being init'ed and the main thread waits for that message before it starts sending messages to the workers.
Contributor
Author
There was a problem hiding this comment.
HAd to move this to satisfy JSLint
|
done reviewing. |
Contributor
|
Open to @dloverin. |
…erminated before it is finished.
dloverin
pushed a commit
that referenced
this pull request
May 24, 2013
Clean up tern web workers whenever we re-init the tern server, or close ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...a project.
If we don't call terminate on the worker, it appears that the worker, and all the memory it's using will never get collected. So when we were switching projects, we were leaving behind orphaned workers, resulting in a large memory leak.
To enable re-initing the web worker I had to change around the logic - now the worker sends a message when it is done being init'ed and the main thread waits for that message before it starts sending messages to the workers.