Fix: Link icon more noticable#415
Conversation
|
Didn't see this before I opened #416. My solution was a lot "dumber" in that I just adjust the opacity, so fixing up the general look might be the better way to go here. I think it looks a little odd right now in dark mode on a skinny screen. Maybe too much padding?
{
position: absolute;
bottom: 2px;
right: 2px;
padding: 2px;
font-size: 1em;
color: white;
/* I didn't change anything else */
} |
|
@rsammelson of the two of yours, I like the skinnier better! But that's just my opinion! But I'm honestly not the guy that anybody goes to for UX decisions, so I think this is better decided by others. |
|
@mdecourcy the first image I took was of yours, the second is a modification of yours. |
|
@GitBarns would you like to weigh in here as well? |
|
Since the compass icon is for Safari, and we target other platforms as well, I would prefer to keep the globe. |
|
@rsammelson they all look pretty good to me! Wonder if we should take this a step deeper, and make background/icon color dependent on if the user has light/dark mode enabled? |
|
@mdecourcy, that's what I did. That's why it looks different between the two modes. I probably was confusing again but those pictures are all from the same code. |
|
Oh, awesome! Yeah I'd say commit that. |
|
Alright, see mdecourcy#3. |
|
lgtm, merging |
Further adjust the link icon
|
I can't believe I forgot to format it 🤦🏼♂️ |
|
@mdecourcy I made some adjustments- switched out the icon for the "link" icon like we have in the embed component. This makes it consistent which is nice. Check out out and lmk what you think-
|
|
Looks good to me @aeharding ! |
|
|











Resolves #408
Not a UX guy, so I'm very open to discussion here and won't take offense if anybody hates it.
Preview:
Before:

After:

Alternatively, but uncommitted:

Also uncommitted:
Apollo reference: (taken from above issue)

Summary of changes:
Set the icon color to white for better visibility, used a circular border radius, increase the opacity, added a box-shadow to create a subtle depth effect