Skip to content

Fix: Link icon more noticable#415

Merged
aeharding merged 6 commits intoaeharding:mainfrom
mdecourcy:fix/linkIcon
Jul 19, 2023
Merged

Fix: Link icon more noticable#415
aeharding merged 6 commits intoaeharding:mainfrom
mdecourcy:fix/linkIcon

Conversation

@mdecourcy
Copy link
Copy Markdown
Contributor

@mdecourcy mdecourcy commented Jul 13, 2023

Resolves #408

Not a UX guy, so I'm very open to discussion here and won't take offense if anybody hates it.

Preview:

Before:
image

After:
image

Alternatively, but uncommitted:
image

Also uncommitted:

image

Apollo reference: (taken from above issue)
image

Summary of changes:

Set the icon color to white for better visibility, used a circular border radius, increase the opacity, added a box-shadow to create a subtle depth effect

@rsammelson
Copy link
Copy Markdown
Contributor

rsammelson commented Jul 13, 2023

Didn't see this before I opened #416. My solution was a lot "dumber" in that I just adjust the opacity, so fixing up the general look might be the better way to go here.

I think it looks a little odd right now in dark mode on a skinny screen. Maybe too much padding?

Is this better?

{
  position: absolute;
  bottom: 2px;
  right: 2px;
  padding: 2px;
  font-size: 1em;
  color: white;

  /* I didn't change anything else */
}

@mdecourcy
Copy link
Copy Markdown
Contributor Author

@rsammelson of the two of yours, I like the skinnier better! But that's just my opinion! But I'm honestly not the guy that anybody goes to for UX decisions, so I think this is better decided by others.

@rsammelson
Copy link
Copy Markdown
Contributor

rsammelson commented Jul 13, 2023

@mdecourcy the first image I took was of yours, the second is a modification of yours.

Here is mine:

@rsammelson
Copy link
Copy Markdown
Contributor

@GitBarns would you like to weigh in here as well?

@mdecourcy
Copy link
Copy Markdown
Contributor Author

Also just found a compassOutline which more closely resembles apollo.

image

@rsammelson
Copy link
Copy Markdown
Contributor

Since the compass icon is for Safari, and we target other platforms as well, I would prefer to keep the globe.

@rsammelson
Copy link
Copy Markdown
Contributor

rsammelson commented Jul 13, 2023

Alright I messed with what you had some more and here's what I came up with:

I haven't committed it yet but if I should let me know.

@mdecourcy
Copy link
Copy Markdown
Contributor Author

@rsammelson they all look pretty good to me! Wonder if we should take this a step deeper, and make background/icon color dependent on if the user has light/dark mode enabled?

@rsammelson
Copy link
Copy Markdown
Contributor

@mdecourcy, that's what I did. That's why it looks different between the two modes. I probably was confusing again but those pictures are all from the same code.

@mdecourcy
Copy link
Copy Markdown
Contributor Author

Oh, awesome! Yeah I'd say commit that.

@rsammelson
Copy link
Copy Markdown
Contributor

Alright, see mdecourcy#3.

@mdecourcy
Copy link
Copy Markdown
Contributor Author

lgtm, merging

mdecourcy and others added 2 commits July 12, 2023 20:52
@rsammelson
Copy link
Copy Markdown
Contributor

I can't believe I forgot to format it 🤦🏼‍♂️

@aeharding
Copy link
Copy Markdown
Owner

@mdecourcy I made some adjustments- switched out the icon for the "link" icon like we have in the embed component. This makes it consistent which is nice. Check out out and lmk what you think-

image image

@mdecourcy
Copy link
Copy Markdown
Contributor Author

Looks good to me @aeharding !

@rsammelson
Copy link
Copy Markdown
Contributor

rsammelson commented Jul 18, 2023

What does it look like in dark mode? Looks good to me.

@aeharding aeharding merged commit 8376537 into aeharding:main Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Add visual hint to thumbnail type in the feed

3 participants