Fix a regression supporting Unicode in Python 2#41
Merged
Conversation
Member
Author
|
This fixes #40 |
deldesir
added a commit
to deldesir/rivescript-python
that referenced
this pull request
Mar 21, 2026
Fix a regression supporting Unicode in Python 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After reorganizing the code in #30, some of the new Python modules stopped importing
unicode_literalswhich broke cases where Unicode strings were interpolated into quoted strings.Additionally, the interactive mode needed to decode the user's input message only for Python 2 because it was an ASCII string by default when it needed to be Unicode. Under Python 3 the string is already Unicode.
This also adds a unit test that put a Unicode message into a user variable via
<set>/<get>tags which verifies that this change fixed it under Python 2, where the new unit test initially failed.