Skip to content

rename BaseReasoner to SimpleReasoner #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheVinhLuong102 merged 2 commits into from
Oct 5, 2024
Merged

rename BaseReasoner to SimpleReasoner #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c62ed5
rename BaseReasoner to SimpleReasoner
TheVinhLuong102 Oct 5, 2024
7236930
refactor openssa.core.simple submodule
TheVinhLuong102 Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openssa/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
from .core.programming.hierarchical.plan import HTP
from .core.programming.hierarchical.planner import HTPlanner

from .core.reasoning.base import BaseReasoner
from .core.reasoning.ooda import OodaReasoner
from .core.reasoning.simple.simple_reasoner import SimpleReasoner

from .core.resource.file import FileResource

Expand Down
0 openssa/core/reasoning/base/_prompts.py → openssa/core/reasoning/simple/_prompts.py
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions openssa/core/reasoning/base/__init__.py → .../core/reasoning/simple/simple_reasoner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
BASE REASONER
=============

`BaseReasoner` is `OpenSSA`'s basic reasoning implementation,
`SimpleReasoner` is `OpenSSA`'s basic reasoning implementation,
which simply forwards posed problems/questions/tasks to available informational resources,
and aggregates answers from such resources without much further analysis.
"""
Expand All @@ -29,8 +29,8 @@


@dataclass
class BaseReasoner(AbstractReasoner):
"""Base Reasoner."""
class SimpleReasoner(AbstractReasoner):
"""Simple Reasoner."""

def reason(self, task: Task, *,
knowledge: set[Knowledge], other_results: list[AskAnsPair] | None = None, n_words: int = 1000) -> str:
Expand Down